[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/28] 9pfs: local: unlinkat: don't follow sy
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/28] 9pfs: local: unlinkat: don't follow symlinks |
Date: |
Mon, 27 Feb 2017 13:14:17 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Sun, Feb 26, 2017 at 11:43:00PM +0100, Greg Kurz wrote:
> The local_unlinkat() callback is vulnerable to symlink attacks because it
> calls remove() which follows symbolic links in all path elements but the
> rightmost one.
>
> This patch converts local_unlinkat() to rely on opendir_nofollow() and
> unlinkat() instead.
>
> Most of the code is moved to a separate local_unlinkat_common() helper
> which will be reused in a subsequent patch to fix the same issue in
> local_remove().
>
> This partly fixes CVE-2016-9602.
>
> Signed-off-by: Greg Kurz <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> v2: - use openat_dir()
> ---
> hw/9pfs/9p-local.c | 99
> +++++++++++++++++++++++++++++-----------------------
> 1 file changed, 56 insertions(+), 43 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 06/28] 9pfs: local: open/opendir: don't follow symlinks, (continued)
- [Qemu-devel] [PATCH v2 07/28] 9pfs: local: lgetxattr: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 08/28] 9pfs: local: llistxattr: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 09/28] 9pfs: local: lsetxattr: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 10/28] 9pfs: local: lremovexattr: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 11/28] 9pfs: local: unlinkat: don't follow symlinks, Greg Kurz, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 11/28] 9pfs: local: unlinkat: don't follow symlinks,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 12/28] 9pfs: local: remove: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 13/28] 9pfs: local: utimensat: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 14/28] 9pfs: local: statfs: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 15/28] 9pfs: local: truncate: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 16/28] 9pfs: local: readlink: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 17/28] 9pfs: local: lstat: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 18/28] 9pfs: local: renameat: don't follow symlinks, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 19/28] 9pfs: local: rename: use renameat, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 20/28] 9pfs: local: improve error handling in link op, Greg Kurz, 2017/02/26
- [Qemu-devel] [PATCH v2 21/28] 9pfs: local: link: don't follow symlinks, Greg Kurz, 2017/02/26