Re: [Qemu-devel] [PATCH 16/21] test-qobject-input-visitor: Use strict visitor

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> The qobject input visitor comes in a strict and a non-strict variant.
>> This test is the non-strict variant's last user.
>
> Well, depending on Paolo's proposed addition.

Needs a commit message tweak if Paolo's goes in first.

>>  Turns out it relies
>> on non-strict only in test_visitor_in_null(), and just out of
>> laziness.  We don't actually test the non-strict behavior.
>> 
>> Clean up test_visitor_in_null(), and switch to the strict variant.
>> The next commit will drop the non-strict variant.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/test-qobject-input-visitor.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> I'm in favor of unifying the two tests into one and reducing the
> duplication (this and the next patch), whether or not we decide that

Patch after next, actually.

> Paolo's patch means we don't want to eliminate non-strict mode.
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!