Re: [Qemu-devel] [PATCH v2 2/3] i386: Make "max" model not use any host CPUID info on TCG

[Eduardo Habkost]

On Fri, Feb 24, 2017 at 01:34:04PM +0100, David Hildenbrand wrote:
> Am 24.02.2017 um 13:32 schrieb Eduardo Habkost:
> > On Fri, Feb 24, 2017 at 12:09:32PM +0100, David Hildenbrand wrote:
> >> Am 22.02.2017 um 19:39 schrieb Eduardo Habkost:
> >>> Instead of reporting host CPUID data on "max", use the qemu64 CPU
> >> Two questions:
> >>
> >> 1. Shouldn't "max" use cpuid of qemu64 with TARGET_X86_64 and qemu32
> >> with !TARGET_X86_64?
> > 
> > qemu32 has family=6,model=6,stepping=3 too, and the only
> > difference on TCG's "max" model on !TARGET_X86_64 will be the
> > lack of CPUID_EXT2_SYSCALL and CPUID_EXT2_LM.
> 
> So this is already handled then, correct?

Yes. I thought you were talking specifically about
family/model/stepping (which is the same on qemu64 and qemu32).

About the rest of the CPUID flags, the qemu64 and qemu32 flags
don't really reflect the TCG capabilities and shouldn't be used
as reference for TCG's "max" model. The TCG capabilities are
found in the TCG_*_FEATURES macros used as values for
FeatureWordInfo::tcg_features.

-- 
Eduardo