qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 24/54] block: Add permissions to blk_new()


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 24/54] block: Add permissions to blk_new()
Date: Wed, 22 Feb 2017 15:36:50 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 21.02.2017 15:58, Kevin Wolf wrote:
> We want every user to be specific about the permissions it needs, so
> we'll pass the initial permissions as parameters to blk_new(). A user
> only needs to call blk_set_perm() if it wants to change the permissions
> after the fact.
> 
> The permissions are stored in the BlockBackend and applied whenever a
> BlockDriverState should be attached in blk_insert_bs().
> 
> This does not include actually choosing the right set of permissions
> everywhere yet. Instead, the usual FIXME comment is added to each place
> and will be addressed in individual patches.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                          |  2 +-
>  block/backup.c                   |  3 ++-
>  block/block-backend.c            | 21 ++++++++++++++-------
>  block/commit.c                   | 12 ++++++++----
>  block/mirror.c                   |  3 ++-
>  block/qcow2.c                    |  2 +-
>  blockdev.c                       |  4 ++--
>  blockjob.c                       |  3 ++-
>  hmp.c                            |  3 ++-
>  hw/block/fdc.c                   |  3 ++-
>  hw/core/qdev-properties-system.c |  3 ++-
>  hw/ide/qdev.c                    |  3 ++-
>  hw/scsi/scsi-disk.c              |  3 ++-
>  include/sysemu/block-backend.h   |  2 +-
>  migration/block.c                |  3 ++-
>  nbd/server.c                     |  3 ++-
>  tests/test-blockjob.c            |  3 ++-
>  tests/test-throttle.c            |  7 ++++---
>  18 files changed, 53 insertions(+), 30 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]