Re: [Qemu-devel] [PATCH 2/2] virtio: add missing region cache init in virtio_load()

[Stefan Hajnoczi]

On Wed, Feb 22, 2017 at 10:16:53AM +0100, Cornelia Huck wrote:
> > @@ -2062,6 +2068,10 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f, int 
> > version_id)
> >      for (i = 0; i < num; i++) {
> >          if (vdev->vq[i].vring.desc) {
> >              uint16_t nheads;
> > +
> > +            /* All ring addresses have been loaded now... */
> > +            virtio_init_region_cache(vdev, i);
> 
> It feels a bit weird that the region cache was already initialized when
> update rings was called. Should the call to init_region_cache be moved
> from update_rings() to virtio_queue_set_addr()?

Will fix in v2.

Stefan

signature.asc
Description: PGP signature