Re: [Qemu-devel] [PATCH v2 21/30] tests: fix virtio-scsi-test leak

[Paolo Bonzini]

On 21/02/2017 15:14, Marc-André Lureau wrote:
> Spotted by ASAN.
> 
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> ---
>  tests/virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
> index 69220ef07b..0eabd56fd9 100644
> --- a/tests/virtio-scsi-test.c
> +++ b/tests/virtio-scsi-test.c
> @@ -63,7 +63,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
>          qvirtqueue_cleanup(vs->dev->bus, vs->vq[i], vs->qs->alloc);
>      }
>      qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, 
> vdev));
> -    g_free(vs->dev);
> +    qvirtio_pci_device_free((QVirtioPCIDevice *)vs->dev);
>      qvirtio_scsi_stop(vs->qs);
>      g_free(vs);
>  }
> 

Reviewed-by: Paolo Bonzini <address@hidden>