Re: [Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

[Dr. David Alan Gilbert]

* Eric Blake (address@hidden) wrote:
> Commit 7a9877a made the 'device' parameter to BlockIOThrottle
> optional, favoring 'id' instead.  But it forgot to update the
> HMP usage to set has_device, which makes all attempts to change
> throttling via HMP fail with "Need exactly one of 'device' and 'id'"
> 
> CC: address@hidden
> Signed-off-by: Eric Blake <address@hidden>

Queued for HMP

> ---
> 
>  hmp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hmp.c b/hmp.c
> index b869617..a3dc9d6 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1551,6 +1551,7 @@ void hmp_block_set_io_throttle(Monitor *mon, const 
> QDict *qdict)
>  {
>      Error *err = NULL;
>      BlockIOThrottle throttle = {
> +        .has_device = true,
>          .device = (char *) qdict_get_str(qdict, "device"),
>          .bps = qdict_get_int(qdict, "bps"),
>          .bps_rd = qdict_get_int(qdict, "bps_rd"),
> -- 
> 2.9.3
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK