Re: [Qemu-devel] [PATCH 07/14] Don't check qobject

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject

From:	Eric Blake
Subject:	Re: [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict()
Date:	Tue, 21 Feb 2017 09:05:32 -0600
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/17/2017 02:38 PM, Markus Armbruster wrote:
> qobject_to_qdict(obj) returns NULL when obj isn't a QDict.  Check
> that instead of qobject_type(obj) == QTYPE_QDICT.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), (continued)
- [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), Eric Blake, 2017/02/17
    - Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), Markus Armbruster, 2017/02/18
- [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), Eric Blake, 2017/02/21
- [Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit(), Eric Blake, 2017/02/21
- [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), Eric Blake, 2017/02/21
- [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Eric Blake <=
- [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Eric Blake, 2017/02/21
- [Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some, Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some, Eric Blake, 2017/02/18
- [Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit, Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit, Eric Blake, 2017/02/21
- [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit, Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit, Eric Blake, 2017/02/20
- [Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj(), Markus Armbruster, 2017/02/17
  - Re: [Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj(), Eric Blake, 2017/02/18

Prev by Date: Re: [Qemu-devel] [PULL 00/11] Changes to -drive without if= and with if=scsi
Next by Date: Re: [Qemu-devel] [PATCH 1/2] vfio/platform: make the vfio-platform device non abstract
Previous by thread: [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict()
Next by thread: [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring()
Index(es):
- Date
- Thread