[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 05/10] target/ppc: update overflow flags for
From: |
Nikunj A Dadhania |
Subject: |
Re: [Qemu-devel] [PATCH v1 05/10] target/ppc: update overflow flags for add/sub |
Date: |
Tue, 21 Feb 2017 14:52:51 +0530 |
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Richard Henderson <address@hidden> writes:
> On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
>> tcg_temp_free(t0);
>> + tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
>> + tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
>> if (NARROW_MODE(ctx)) {
>> - tcg_gen_ext32s_tl(cpu_ov, cpu_ov);
>> + tcg_gen_mov_tl(cpu_ov, cpu_ov32);
>> }
>> - tcg_gen_shri_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1);
>
> Don't compute ov32 only to overwrite it again. Move the ov32 extraction into
> an else of NARROW_MODE.
Sure.
Regards
Nikunj
- [Qemu-devel] [PATCH v1 10/10] target/ppc: add mcrxrx instruction, (continued)
- [Qemu-devel] [PATCH v1 02/10] target/ppc: Update ca32 in arithmetic add, Nikunj A Dadhania, 2017/02/20
- [Qemu-devel] [PATCH v1 05/10] target/ppc: update overflow flags for add/sub, Nikunj A Dadhania, 2017/02/20
- [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Nikunj A Dadhania, 2017/02/20
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Richard Henderson, 2017/02/20
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Nikunj A Dadhania, 2017/02/21
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Richard Henderson, 2017/02/21
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Nikunj A Dadhania, 2017/02/21
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Richard Henderson, 2017/02/22
- Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego, Nikunj A Dadhania, 2017/02/22
[Qemu-devel] [PATCH v1 09/10] target/ppc: add ov32 flag in divide operations, Nikunj A Dadhania, 2017/02/20
[Qemu-devel] [PATCH v1 04/10] target/ppc: compute ca32 for arithmetic substract, Nikunj A Dadhania, 2017/02/20