[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi ra
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D |
|
Date: |
Fri, 17 Feb 2017 09:50:06 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/17/2017 09:12 AM, Peter Maydell wrote:
> Unfortunately some older versions of makeinfo don't correctly
> handle the -D command line option and fail to set the variable.
> This then causes them to complain
> docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION
>
> Work around this by doing as the autotools do, and writing
> the information into a version.texi file which we then
> include from the .texi files that need it.
Autotools defines a few more macros, but we can always beef up our
version.texi if we find ourselves needing any of them.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Makefile | 17 ++++++++++-------
> docs/qemu-ga-ref.texi | 2 ++
> docs/qemu-qmp-ref.texi | 2 ++
> 3 files changed, 14 insertions(+), 7 deletions(-)
Missing a change to .gitignore for version.texi. With that fixed, you
can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature