Re: [Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

[Ben Warren]

> On Feb 15, 2017, at 1:35 PM, Eric Blake <address@hidden> wrote:
> 
> On 02/15/2017 12:15 AM, address@hidden <mailto:address@hidden> wrote:
>> From: Ben Warren <address@hidden>
>> 
>> Also usable by upcoming VM Generation ID tests
>> 
>> Signed-off-by: Ben Warren <address@hidden>
>> ---
>> tests/acpi-utils.h       | 75 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> tests/bios-tables-test.c | 72 +---------------------------------------------
>> 2 files changed, 76 insertions(+), 71 deletions(-)
>> create mode 100644 tests/acpi-utils.h
>> 
>> diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
>> new file mode 100644
>> index 0000000..d5e5eff
>> --- /dev/null
>> +++ b/tests/acpi-utils.h
>> @@ -0,0 +1,75 @@
>> +#ifndef TEST_ACPI_UTILS_H
>> +#define TEST_ACPI_UTILS_H
> 
> No copyright blurb? Also, does MAINTAINERS need an update to cover the
> new file?
> 
Sure, I didn’t realize the header files all have copyright headers.  As for 
MAINTAINERS, do you mean I should add a device entry for vmgenid?

thanks,
Ben
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org <http://libvirt.org/>

smime.p7s
Description: S/MIME cryptographic signature