Re: [Qemu-devel] [PATCH v4 2/3] report guest crash information in GUEST_PANICKED event

[Eric Blake]

On 02/14/2017 12:25 AM, Denis V. Lunev wrote:
> From: Anton Nefedov <address@hidden>
> 
> it's not very convenient to use the crash-information property interface,
> so provide a CPU class callback to get the guest crash information, and pass
> that information in the event
> 
> Signed-off-by: Anton Nefedov <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> ---

> +++ b/qapi/event.json
> @@ -488,7 +488,9 @@
>  #
>  # @action: action that has been taken, currently always "pause"
>  #
> -# Since: 1.5
> +# @info: optional information about a panic
> +#
> +# Since: 1.5 (@info since 2.9)

This is more usually written:

# @info: #optional information about a panic (since 2.9)
#
# Since: 1.5


> +
> +    if (info) {
> +        qapi_free_GuestPanicInformation(info);

qapi_free_*() is safe to call on a NULL pointer, so this is a useless 'if'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature