Re: [Qemu-devel] 答复： Re: [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp

[Lin Ma]

>>> Paolo Bonzini <address@hidden> 2017/2/13 星期一 下午 7:55 >>>
>
>
>On 13/02/2017 12:53, Lin Ma wrote:
>> 
>> The content of qemu-version.h recorded the git head info of last build.
>> After 'git pull && make ', Because the content of qemu-version.h.tmp is
>> generated
>> based on the lastest git describe, Now this .h.tmp and the old .h aren't
>> consistent,
>> So this .h.tmp will be renamed to qemu-version.h.
>> Then during 'sudo make install', because there is no .h.tmp any more, a
>> new one will be
>> generated with privileged permissions.
>
>So is the bug that the "cmp || mv" should be changed to "if cmp ...;
>then mv ...; else rm ..."?
Yes, It makes sense, and this way can avoid leaving the qemu-version.h.tmp in
the folder after build. I'll send patch v3 based on it and the patch title will 
be
changed to 'avoid leaving the temporary QEMU_PKGVERSION header file'.
 
Thanks,
Lin