[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 RESEND] Makefile: Fix owner and group for qem
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp |
|
Date: |
Mon, 13 Feb 2017 11:07:00 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 13/02/2017 10:51, Lin Ma wrote:
> By commit 67a1de0d, When we perform 'git pull && make && sudo make install',
> In 'make' stage a qemu-version.h.tmp will be generated. If the content of
> qemu-version.h.tmp and qemu-version.h aren't consistent, The
> qemu-version.h.tmp
> will be renamed to qemu-version.h. Because of the target FORCE, The same
> action
> will be do again in 'make install' stage.
But why does the content of .h and .h.tmp not match during "make install"?
Paolo
> diff --git a/Makefile b/Makefile
> index 1a8bfb2..1ca45b2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -184,7 +184,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > address@hidden)
> - $(call quiet-command, cmp -s $@ address@hidden || mv address@hidden $@)
> + $(call quiet-command, cmp -s $@ address@hidden || cp address@hidden $@)