[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to cryp
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to crypto layer |
Date: |
Sun, 12 Feb 2017 03:39:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 10.02.2017 18:09, Daniel P. Berrange wrote:
> While the crypto layer uses a fixed option name "key-secret",
> the upper block layer may have a prefix on the options. e.g.
> "luks-key-secret", "aes-key-secret", in order to avoid clashes
> between crypto option names & other block option names. To
> ensure the crypto layer can report accurate error messages,
> we must tell it what option name prefix was used.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> block/crypto.c | 4 ++--
> block/qcow.c | 7 ++++---
> block/qcow2.c | 15 +++++++++------
> crypto/block-luks.c | 8 ++++++--
> crypto/block-qcow.c | 8 ++++++--
> crypto/block.c | 6 ++++--
> crypto/blockpriv.h | 2 ++
> include/crypto/block.h | 6 +++++-
> tests/test-crypto-block.c | 8 ++++----
> 9 files changed, 42 insertions(+), 22 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place, (continued)
- [Qemu-devel] [PATCH v4 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 12/18] qcow2: extend specification to cover LUKS encryption, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 14/18] qcow2: add iotests to cover LUKS encryption support, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 15/18] iotests: enable tests 134 and 158 to work with qcow (v1), Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 16/18] block: rip out all traces of password prompting, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 17/18] block: remove all encryption handling APIs, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 13/18] qcow2: add support for LUKS encryption format, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to crypto layer, Daniel P. Berrange, 2017/02/10
- Re: [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to crypto layer,
Max Reitz <=