[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/prom-env: Ease time-out problems on slow
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH] tests/prom-env: Ease time-out problems on slow hosts |
Date: |
Fri, 10 Feb 2017 10:15:17 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Feb 09, 2017 at 02:37:26PM +0000, Peter Maydell wrote:
> On 9 February 2017 at 14:13, Thomas Huth <address@hidden> wrote:
> > Peter Maydell recently ran into time-out problems with the
> > prom-env test on a rather slow ARM board. To tackle this issue,
> > we can speed up the test by running QEMU with "-nodefaults" here,
> > so that SLOF has less devices to scan during boot, and by using
> > the "nvramrc" environment variable instead of "boot-command",
> > since this variable is evaluated earlier in the boot process.
> > And to be really sure that we do not face such time out problems
> > again, let's also increase the time out value from 100s to 120s
> > instead.
> >
> > Signed-off-by: Thomas Huth <address@hidden>
> > ---
> > tests/prom-env-test.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
>
> Seems to cut the elapsed realtime for the pseries board
> down from about 90s to 55s. Hopefully that plus the
> boosted timeout will help.
>
> Tested-by: Peter Maydell <address@hidden>
Peter, will you merge this directly, or do you want me to take it
through my tree?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature