[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/10] qmp/hmp: add set-vm-generation-id comm
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v5 07/10] qmp/hmp: add set-vm-generation-id commands |
Date: |
Wed, 8 Feb 2017 23:01:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/05/17 10:12, address@hidden wrote:
> From: Igor Mammedov <address@hidden>
>
> Add set-vm-generation-id command to set Virtual Machine
> Generation ID counter.
>
> QMP command example:
> { "execute": "set-vm-generation-id",
> "arguments": {
> "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"
> }
> }
>
> HMP command example:
> set-vm-generation-id guid=324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Ben Warren <address@hidden>
> ---
> hmp-commands.hx | 13 +++++++++++++
> hmp.c | 12 ++++++++++++
> hmp.h | 1 +
> hw/acpi/vmgenid.c | 12 ++++++++++++
> qapi-schema.json | 11 +++++++++++
> stubs/vmgenid.c | 6 ++++++
> 6 files changed, 55 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 8819281..56744aa 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1775,5 +1775,18 @@ ETEXI
> },
>
> STEXI
> address@hidden set-vm-generation-id @var{uuid}
> +Set Virtual Machine Generation ID counter to @var{guid}
> +ETEXI
> +
> + {
> + .name = "set-vm-generation-id",
> + .args_type = "guid:s",
> + .params = "guid",
> + .help = "Set Virtual Machine Generation ID counter",
> + .cmd = hmp_set_vm_generation_id,
> + },
> +
> +STEXI
> @end table
> ETEXI
> diff --git a/hmp.c b/hmp.c
> index 535613d..39c8965 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2574,3 +2574,15 @@ void hmp_info_vm_generation_id(Monitor *mon, const
> QDict *qdict)
> }
> qapi_free_GuidInfo(info);
> }
> +
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict)
> +{
> + Error *errp = NULL;
> + const char *guid = qdict_get_str(qdict, "guid");
> +
> + qmp_set_vm_generation_id(guid, &errp);
> + if (errp) {
> + hmp_handle_error(mon, &errp);
> + return;
This return statement is superfluous.
> + }
> +}
> diff --git a/hmp.h b/hmp.h
> index 799fd37..e0ac1e8 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -138,5 +138,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict
> *qdict);
> void hmp_info_dump(Monitor *mon, const QDict *qdict);
> void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
> void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict);
>
> #endif
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index e148051..af8b35c 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -224,3 +224,15 @@ GuidInfo *qmp_query_vm_generation_id(Error **errp)
> info->guid = qemu_uuid_unparse_strdup(&guid);
> return info;
> }
> +
> +void qmp_set_vm_generation_id(const char *guid, Error **errp)
> +{
> + Object *obj = find_vmgenid_dev(errp);
> +
> + if (!obj) {
> + return;
> + }
> +
> + object_property_set_str(obj, guid, VMGENID_GUID, errp);
> + return;
This too.
> +}
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 384a7f3..ed2657d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -6051,3 +6051,14 @@
> # Since 2.9
> ##
> { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
> +
> +##
> +# @set-vm-generation-id:
> +#
> +# Set Virtual Machine Generation ID
> +#
> +# @guid: new GUID to set as Virtual Machine Generation ID
> +#
> +# Since 2.9
> +##
> +{ 'command': 'set-vm-generation-id', 'data': {'guid': 'str'} }
> diff --git a/stubs/vmgenid.c b/stubs/vmgenid.c
> index 8c448ac..d25d41b 100644
> --- a/stubs/vmgenid.c
> +++ b/stubs/vmgenid.c
> @@ -6,3 +6,9 @@ GuidInfo *qmp_query_vm_generation_id(Error **errp)
> error_setg(errp, "this command is not currently supported");
> return NULL;
> }
> +
> +void qmp_set_vm_generation_id(const char *guid, Error **errp)
> +{
> + error_setg(errp, "this command is not currently supported");
> + return;
And this.
Thanks,
Laszlo
> +}
>
- Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support, (continued)
- [Qemu-devel] [PATCH v5 06/10] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 07/10] qmp/hmp: add set-vm-generation-id commands, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 09/10] tests: Move reusable ACPI macros into a new header file, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 10/10] tests: Add unit tests for the VM Generation ID feature, ben, 2017/02/05
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Laszlo Ersek, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Michael S. Tsirkin, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Andrew Jones, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Andreas Färber, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/13
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Michael S. Tsirkin, 2017/02/13