[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/22] main: free root container
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 05/22] main: free root container |
Date: |
Tue, 7 Feb 2017 15:01:59 -0500 (EST) |
Hi
----- Original Message -----
>
>
> On 02/02/2017 15:51, Marc-André Lureau wrote:
> > This should eventually free all objects that are only referenced by
> > their parents.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> > vl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/vl.c b/vl.c
> > index 0b72b12878..945df1d17f 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -4640,6 +4640,7 @@ int main(int argc, char **argv, char **envp)
> > audio_cleanup();
> > monitor_cleanup();
> > qemu_chr_cleanup();
> > + object_unref(object_get_root());
>
> This seems dangerous. I'm pretty sure that a lot of non-hot-unpluggable
> devices would leak or crash.
make check is ok. Any suggestion what else to check?
This patch was added so that /chardevs container is cleaned up (with the
following patches). Perhaps I could be more conservative and only unref (oops
unparent) /chardevs.
- [Qemu-devel] [PATCH 00/22] chardev clean-ups & tests, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 01/22] char: remove qemu_chr_be_generic_open, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 03/22] xen: use a better chardev type check, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 02/22] mux: simplfy muxes_realize_done, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 04/22] container: don't leak container reference, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 05/22] main: free root container, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/02
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/06
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/07
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/09
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/10
[Qemu-devel] [PATCH 07/22] char: use /chardevs container instead of chardevs list, Marc-André Lureau, 2017/02/02