Re: [Qemu-devel] [PATCH 0/4] block/gluster: cleanups for GlfsPreopened

[Eric Blake]

On 01/27/2017 04:00 AM, Stefan Hajnoczi wrote:
> Code added in commit 6349c15410361d3fe52c9beee309954d606f8ccd ("block/gluster:
> memory usage: use one glfs instance per volume") does not follow conventions
> and violates QEMU coding style.  Although any single issue in isolation is not
> worth patching, there are several of these and I think it's worth resolving
> them together in one sweep.
> 
> Stefan Hajnoczi (4):
>   block/gluster: fix wrong indent in glfs_find_preopened()
>   block/gluster: drop intermediate ListElement struct
>   block/gluster: use conventional names for GlfsPreopened functions
>   block/gluster: add missing QLIST_HEAD_INITIALIZER()

For the series,
Reviewed-by: Eric Blake <address@hidden>

> 
>  block/gluster.c | 66 
> +++++++++++++++++++++++++++------------------------------
>  1 file changed, 31 insertions(+), 35 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature