[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 14/25] cputlb: tweak qemu_ram_addr_from_host_nofa
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v8 14/25] cputlb: tweak qemu_ram_addr_from_host_nofail reporting |
Date: |
Fri, 27 Jan 2017 10:39:11 +0000 |
This moves the helper function closer to where it is called and updates
the error message to report via error_report instead of the deprecated
fprintf.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
cputlb.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index af0e65cd2c..94fa9977c5 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -246,18 +246,6 @@ void tlb_reset_dirty_range(CPUTLBEntry *tlb_entry,
uintptr_t start,
}
}
-static inline ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr)
-{
- ram_addr_t ram_addr;
-
- ram_addr = qemu_ram_addr_from_host(ptr);
- if (ram_addr == RAM_ADDR_INVALID) {
- fprintf(stderr, "Bad ram pointer %p\n", ptr);
- abort();
- }
- return ram_addr;
-}
-
void tlb_reset_dirty(CPUState *cpu, ram_addr_t start1, ram_addr_t length)
{
CPUArchState *env;
@@ -469,6 +457,18 @@ static void report_bad_exec(CPUState *cpu, target_ulong
addr)
log_cpu_state_mask(LOG_GUEST_ERROR, cpu, CPU_DUMP_FPU | CPU_DUMP_CCOP);
}
+static inline ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr)
+{
+ ram_addr_t ram_addr;
+
+ ram_addr = qemu_ram_addr_from_host(ptr);
+ if (ram_addr == RAM_ADDR_INVALID) {
+ error_report("Bad ram pointer %p", ptr);
+ abort();
+ }
+ return ram_addr;
+}
+
/* NOTE: this function can trigger an exception */
/* NOTE2: the returned address is not exactly the physical address: it
* is actually a ram_addr_t (in system mode; the user mode emulation
--
2.11.0
- Re: [Qemu-devel] [PATCH v8 05/25] tcg: add options for enabling MTTCG, (continued)
- [Qemu-devel] [PATCH v8 15/25] cputlb: introduce tlb_flush_* async work., Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 10/25] tcg: enable tb_lock() for SoftMMU, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 11/25] tcg: enable thread-per-vCPU, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 13/25] cputlb: add assert_cpu_is_self checks, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 08/25] tcg: drop global lock during TCG code execution, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 14/25] cputlb: tweak qemu_ram_addr_from_host_nofail reporting,
Alex Bennée <=
- [Qemu-devel] [PATCH v8 20/25] target-arm/powerctl: defer cpu reset work to CPU context, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 12/25] tcg: handle EXCP_ATOMIC exception for system emulation, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 06/25] tcg: add kick timer for single-threaded vCPU emulation, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 09/25] tcg: remove global exit_request, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 16/25] cputlb and arm/sparc targets: convert mmuidx flushes from varg to bitmap, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 22/25] target-arm/cpu.h: make ARM_CP defined consistent, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 18/25] cputlb: atomically update tlb fields used by tlb_reset_dirty, Alex Bennée, 2017/01/27
- [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC, Alex Bennée, 2017/01/27