[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for des
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for descriptor ring |
Date: |
Tue, 24 Jan 2017 12:38:57 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Jan 20, 2017 at 06:07:56PM +0100, Paolo Bonzini wrote:
> @@ -762,15 +761,14 @@ void *virtqueue_pop(VirtQueue *vq, size_t sz)
>
> i = head;
>
> - len = address_space_cache_init(&vring_desc_cache, vdev->dma_as,
> - vq->vring.desc, max * sizeof(VRingDesc),
> - false);
> - desc_cache = &vring_desc_cache;
> - if (len < max * sizeof(VRingDesc)) {
> + rcu_read_lock();
> + caches = atomic_rcu_read(&vq->vring.caches);
> + if (caches->desc.len < max * sizeof(VRingDesc)) {
> virtio_error(vdev, "Cannot map descriptor ring");
> return NULL;
Missing rcu_read_unlock() in all return cases.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 1/7] virtio: make virtio_should_notify static, (continued)
- [Qemu-devel] [PATCH 1/7] virtio: make virtio_should_notify static, Paolo Bonzini, 2017/01/20
- [Qemu-devel] [PATCH 4/7] virtio: use MemoryRegionCache to access descriptors, Paolo Bonzini, 2017/01/20
- [Qemu-devel] [PATCH 3/7] virtio: use address_space_map/unmap to access descriptors, Paolo Bonzini, 2017/01/20
- [Qemu-devel] [PATCH 5/7] virtio: add MemoryListener to cache ring translations, Paolo Bonzini, 2017/01/20
- [Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for descriptor ring, Paolo Bonzini, 2017/01/20
- Re: [Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for descriptor ring,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 7/7] virtio: use VRingMemoryRegionCaches for avail and used rings, Paolo Bonzini, 2017/01/20
- Re: [Qemu-devel] [PATCH 0/7] virtio: use MemoryRegionCache for descriptors and rings, Michael S. Tsirkin, 2017/01/20
- Re: [Qemu-devel] [PATCH 0/7] virtio: use MemoryRegionCache for descriptors and rings, Michael S. Tsirkin, 2017/01/24