Re: [Qemu-devel] [RFC 09/13] numa: introduce '-numa cpu' cpu option

[Igor Mammedov]

On Fri, 20 Jan 2017 14:40:34 +0100
Paolo Bonzini <address@hidden> wrote:

> On 18/01/2017 18:13, Igor Mammedov wrote:
> > It allows to specify mapping of a CPU to NUMA node on CLI.
> > Option should be repeated for each present/possible CPU.
> > Example for PC machine:
> >   -numa node,nodeid=0 -numa node,nodeid=1 \
> >   -numa cpu,socket-id=0,core-id=0,thread-id=0,node-id=0 \
> >   -numa cpu,socket-id=1,core-id=0,thread-id=0,node-id=1
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>  
> 
> What about making core-id/thread-id optional, like
> 
> -numa cpu,socket-id=0,node-id=0
> 
> ?
> 
> Also perhaps change it like this to make it less verbose and match
> "-numa node":
> 
>   -numa node,nodeid=0 -numa cpus,nodeid=0,socket=0 \
>   -numa node,nodeid=1 -numa cpus,nodeid=1,socket=1

the reason, I've made it strict/mandatory is that it's becomes
trivial property setting and matches mandatory options for -device 
x86-foo-cpu,...

we can always make it less strict afterwards but not other way around,
but I can try to make it less strict on respin.

> (Yeah, I know, bikeshedding).
> 
> Paolo