[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC v4 03/20] vfio: allow to notify unmap for very l
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH RFC v4 03/20] vfio: allow to notify unmap for very large region |
Date: |
Fri, 20 Jan 2017 21:08:39 +0800 |
Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big
region. This can be leveraged by QEMU IOMMU implementation to cleanup
existing page mappings for an entire iova address space (by notifying
with an IOTLB with extremely huge addr_mask). However current
vfio_iommu_map_notify() does not allow that. It make sure that all the
translated address in IOTLB is falling into RAM range.
The check makes sense, but it should only be a sensible checker for
mapping operations, and mean little for unmap operations.
This patch moves this check into map logic only, so that we'll get
faster unmap handling (no need to translate again), and also we can then
better support unmapping a very big region when it covers non-ram ranges
or even not-existing ranges.
Signed-off-by: Peter Xu <address@hidden>
---
hw/vfio/common.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index ce55dff..4d90844 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -354,11 +354,10 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n,
IOMMUTLBEntry *iotlb)
return;
}
- if (!vfio_get_vaddr(iotlb, &vaddr, &read_only)) {
- return;
- }
-
if ((iotlb->perm & IOMMU_RW) != IOMMU_NONE) {
+ if (!vfio_get_vaddr(iotlb, &vaddr, &read_only)) {
+ return;
+ }
ret = vfio_dma_map(container, iova,
iotlb->addr_mask + 1, vaddr,
read_only);
--
2.7.4
- [Qemu-devel] [PATCH RFC v4 00/20] VT-d: vfio enablement and misc enhances, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 03/20] vfio: allow to notify unmap for very large region,
Peter Xu <=
- [Qemu-devel] [PATCH RFC v4 04/20] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 05/20] intel_iommu: simplify irq region translation, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 06/20] intel_iommu: renaming gpa to iova where proper, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 07/20] intel_iommu: fix trace for inv desc handling, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 08/20] intel_iommu: fix trace for addr translation, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 09/20] intel_iommu: vtd_slpt_level_shift check level, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 10/20] memory: add section range info for IOMMU notifier, Peter Xu, 2017/01/20