Re: [Qemu-devel] [PATCH v6 1/5] block/vvfat: Remove the undesirable comment

[Dr. David Alan Gilbert]

* Ashijeet Acharya (address@hidden) wrote:
> Remove the "// assert(is_consistent(s))" comment in block/vvfat.c
> 
> Signed-off-by: Ashijeet Acharya <address@hidden>

It looks like it's been commented out for about 11 years now - it can go.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  block/vvfat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index ded2109..7b706dc 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1189,7 +1189,6 @@ static int vvfat_open(BlockDriverState *bs, QDict 
> *options, int flags,
>          init_mbr(s, cyls, heads, secs);
>      }
>  
> -    //    assert(is_consistent(s));
>      qemu_co_mutex_init(&s->lock);
>  
>      /* Disable migration when vvfat is used rw */
> -- 
> 2.6.2
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK