[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON |
Date: |
Wed, 18 Jan 2017 23:16:07 +0200 |
On Wed, Jan 18, 2017 at 09:04:03PM +0000, Peter Maydell wrote:
> On 18 January 2017 at 20:55, Michael S. Tsirkin <address@hidden> wrote:
> > All users include the trailing ;, let's require that
> > so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not
> > produce unexpected results.
>
> When would it ever make sense for a build-time
> assert to be the only thing inside a runtime
> conditional anyway?
>
> thanks
> -- PMM
What do I know? Do you want to keep the trailing ; in there?
I can drop this patch.
--
MST
[Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Michael S. Tsirkin, 2017/01/18
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Markus Armbruster, 2017/01/19
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Paolo Bonzini, 2017/01/19
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Markus Armbruster, 2017/01/19
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Michael S. Tsirkin, 2017/01/19
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Eric Blake, 2017/01/19
- Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON, Michael S. Tsirkin, 2017/01/19