Re: [Qemu-devel] [PATCH 0/4] virtio: ARRAY_SIZE fixups

[Michael S. Tsirkin]

On Wed, Jan 18, 2017 at 12:40:50PM -0800, address@hidden wrote:
> Hi,
> 
> Your series seems to have some coding style problems. See output below for
> more information:

Not sure we really do care as this matches existing code, but I'll fix
it up.


> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH 0/4] virtio: ARRAY_SIZE fixups
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 38b031b ARRAY_SIZE: check that argument is an array
> 19ef003 compiler: expression version of QEMU_BUILD_BUG_ON
> 71870e6 compiler: drop ; after BUILD_BUG_ON
> c652d79 virtio: fix up max size checks
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/4: virtio: fix up max size checks...
> Checking PATCH 2/4: compiler: drop ; after BUILD_BUG_ON...
> WARNING: line over 80 characters
> #25: FILE: include/qemu/compiler.h:89:
> +    typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
> __attribute__((unused))
> 
> ERROR: space required after that ',' (ctx:VxV)
> #25: FILE: include/qemu/compiler.h:89:
> +    typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
> __attribute__((unused))
>                                           ^
> 
> ERROR: spaces required around that '?' (ctx:VxO)
> #25: FILE: include/qemu/compiler.h:89:
> +    typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
> __attribute__((unused))
>                                                         ^
> 
> ERROR: space required before that '-' (ctx:OxV)
> #25: FILE: include/qemu/compiler.h:89:
> +    typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
> __attribute__((unused))
>                                                          ^
> 
> ERROR: spaces required around that ':' (ctx:VxV)
> #25: FILE: include/qemu/compiler.h:89:
> +    typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
> __attribute__((unused))
>                                                            ^
> 
> total: 4 errors, 1 warnings, 8 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 3/4: compiler: expression version of QEMU_BUILD_BUG_ON...
> ERROR: spaces required around that '?' (ctx:VxO)
> #23: FILE: include/qemu/compiler.h:91:
> +#define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(int[(x)?-1:1]) - sizeof(int))
>                                                   ^
> 
> ERROR: space required before that '-' (ctx:OxV)
> #23: FILE: include/qemu/compiler.h:91:
> +#define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(int[(x)?-1:1]) - sizeof(int))
>                                                    ^
> 
> ERROR: spaces required around that ':' (ctx:VxV)
> #23: FILE: include/qemu/compiler.h:91:
> +#define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(int[(x)?-1:1]) - sizeof(int))
>                                                      ^
> 
> total: 3 errors, 0 warnings, 8 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 4/4: ARRAY_SIZE: check that argument is an array...
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden