[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] linux-user: fix tcg/mmap test
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] linux-user: fix tcg/mmap test |
Date: |
Wed, 18 Jan 2017 16:21:34 +0000 |
On 18 January 2017 at 15:02, Pranith Kumar <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> tests/tcg/mmap test fails with values other than default target page
> size. When creating a map beyond EOF, extra anonymous pages are added up
> to the target page boundary. Currently, this operation is performed only
> when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it should be
> performed if the configured page size (qemu -p) is larger than
> qemu_real_host_page_size too.
>
> (also fixes some style issues to please checkpatch)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Pranith Kumar <address@hidden>
This got reviewed-by with caveats from two people when
it was last sent but you have neither included the R-by
tags nor addressed the minor tweaks they asked you to
address.
thanks
-- PMM