Re: [Qemu-devel] [PATCH RFC v2 5/6] replication: Implement block replication for shared disk case

[Stefan Hajnoczi]

On Mon, Dec 05, 2016 at 04:35:03PM +0800, zhanghailiang wrote:
> @@ -663,8 +695,12 @@ static void replication_stop(ReplicationState *rs, bool 
> failover, Error **errp)
>  
>      switch (s->mode) {
>      case REPLICATION_MODE_PRIMARY:
> -        s->replication_state = BLOCK_REPLICATION_DONE;
> -        s->error = 0;
> +        if (s->is_shared_disk && s->primary_disk->bs->job) {
> +            block_job_cancel(s->primary_disk->bs->job);

Should this be block_job_cancel_sync()?

> +        } else {
> +            s->replication_state = BLOCK_REPLICATION_DONE;
> +            s->error = 0;
> +        }
>          break;
>      case REPLICATION_MODE_SECONDARY:
>          /*
> -- 
> 1.8.3.1
> 
>

signature.asc
Description: PGP signature