[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/11] async: optimize aio_bh_poll
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 11/11] async: optimize aio_bh_poll |
Date: |
Mon, 16 Jan 2017 13:39:11 +0000 |
From: Paolo Bonzini <address@hidden>
Avoid entering the slow path of qemu_lockcnt_dec_and_lock if
no bottom half has to be deleted.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
async.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/async.c b/async.c
index 2305e11..0d218ab 100644
--- a/async.c
+++ b/async.c
@@ -92,6 +92,7 @@ int aio_bh_poll(AioContext *ctx)
{
QEMUBH *bh, **bhp, *next;
int ret;
+ bool deleted = false;
qemu_lockcnt_inc(&ctx->list_lock);
@@ -112,9 +113,17 @@ int aio_bh_poll(AioContext *ctx)
bh->idle = 0;
aio_bh_call(bh);
}
+ if (bh->deleted) {
+ deleted = true;
+ }
}
/* remove deleted bhs */
+ if (!deleted) {
+ qemu_lockcnt_dec(&ctx->list_lock);
+ return ret;
+ }
+
if (qemu_lockcnt_dec_and_lock(&ctx->list_lock)) {
bhp = &ctx->first_bh;
while (*bhp) {
@@ -128,7 +137,6 @@ int aio_bh_poll(AioContext *ctx)
}
qemu_lockcnt_unlock(&ctx->list_lock);
}
-
return ret;
}
--
2.9.3
- [Qemu-devel] [PULL 00/11] Block patches, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 01/11] block: get rid of bdrv_io_unplugged_begin/end, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 02/11] aio: rename bh_lock to list_lock, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 03/11] qemu-thread: introduce QemuLockCnt, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 04/11] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 06/11] aio-posix: split aio_dispatch_handlers out of aio_dispatch, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 05/11] qemu-thread: optimize QemuLockCnt with futexes on Linux, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 07/11] aio: tweak walking in dispatch phase, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 08/11] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 09/11] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock, Stefan Hajnoczi, 2017/01/16
- [Qemu-devel] [PULL 11/11] async: optimize aio_bh_poll,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 10/11] aio: document locking, Stefan Hajnoczi, 2017/01/16
- Re: [Qemu-devel] [PULL 00/11] Block patches, Peter Maydell, 2017/01/17