Re: [Qemu-devel] [PATCH v4 6/6] hypertrace: Add guest-side Linux module

[Stefan Hajnoczi]

On Sun, Jan 15, 2017 at 03:10:13AM +0100, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> > On Mon, Dec 26, 2016 at 09:35:10PM +0100, Lluís Vilanova wrote:
> >> Provides guest Linux kernel module "qemu-hypertrace.ko" to abstract
> >> access to the hypertrace channel.
> >> 
> >> Signed-off-by: Lluís Vilanova <address@hidden>
> >> ---
> >> Makefile                                           |    4 -
> >> configure                                          |    4 +
> >> hypertrace/guest/linux-module/Kbuild.in            |    7 +
> >> hypertrace/guest/linux-module/Makefile             |   23 +++
> >> .../include/linux/qemu-hypertrace-internal.h       |   46 ++++++
> >> .../linux-module/include/linux/qemu-hypertrace.h   |   73 ++++++++++
> >> hypertrace/guest/linux-module/qemu-hypertrace.c    |  149 
> >> ++++++++++++++++++++
> >> 7 files changed, 305 insertions(+), 1 deletion(-)
> >> create mode 100644 hypertrace/guest/linux-module/Kbuild.in
> >> create mode 100644 hypertrace/guest/linux-module/Makefile
> >> create mode 100644 
> >> hypertrace/guest/linux-module/include/linux/qemu-hypertrace-internal.h
> >> create mode 100644 
> >> hypertrace/guest/linux-module/include/linux/qemu-hypertrace.h
> >> create mode 100644 hypertrace/guest/linux-module/qemu-hypertrace.c
> 
> > This should be submitted to Linux, the module cannot live in the QEMU
> > tree (we don't carry out-of-tree kernel modules).
> 
> I thought it made sense to have it here, the same way we have the user-mode
> guest library. If not, I will split it into a separate repo and point at it 
> from
> the documentation file. Once the rest is merged into QEMU, I can post the 
> kernel
> module repo to the linux list.

Linux doesn't have a stable kernel module API.  Out-of-tree modules
bitrot if they are not actively rebased.  Getting the module into
linux.git avoids these problems.

The Linux maintainers may give you feedback that requires changes to the
current design, so please send the patch to them now instead of waiting.

Stefan

signature.asc
Description: PGP signature