[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 12/21] qapi.py: fix line break before binary
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v8 12/21] qapi.py: fix line break before binary operator pep8 |
Date: |
Fri, 13 Jan 2017 17:46:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> ----- Original Message -----
>> Marc-André Lureau <address@hidden> writes:
>>
>> > Python code style accepts both form, but pep8 complains. Better to clean
>> > up the single warning for now, so new errors stand out more easily.
>> >
>> > Fix scripts/qapi.py:1539:21: W503 line break before binary operator
>> >
>> > Signed-off-by: Marc-André Lureau <address@hidden>
>>
>> I'm dropping this patch, as per review of v7.
>
> Sorry, I thought I dropped it. I think I screwed up with my two branches
> (maintaining both split/squash series was quite a pain, I am relieved we are
> nearing the end)
Don't worry, you did all the non-trivial changes correctly, so I'm happy
to do a few trivial ones :)
- [Qemu-devel] [PATCH v8 06/21] qga/schema: improve guest-set-vcpus Returns: section, (continued)
- [Qemu-devel] [PATCH v8 06/21] qga/schema: improve guest-set-vcpus Returns: section, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 07/21] qapi: avoid interleaving sections and parameters, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 09/21] qapi: add some sections in docs, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 10/21] docs: add master qapi texi files, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 08/21] qapi: move experimental note down, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 12/21] qapi.py: fix line break before binary operator pep8, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 11/21] qapi: rework qapi Exception, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 13/21] texi2pod: learn quotation, deftp and deftypefn, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 17/21] build-sys: use --no-split for info, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 16/21] docs: add qemu logo to pdf, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 18/21] build-sys: remove dvi doc generation, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 19/21] build-sys: use a generic TEXI2MAN rule, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 20/21] build-sys: add txt documentation rules, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 21/21] build-sys: add qapi doc generation targets, Marc-André Lureau, 2017/01/13
- [Qemu-devel] [PATCH v8 15/21] qapi: add qapi2texi script, Marc-André Lureau, 2017/01/13