[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-ta
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h |
Date: |
Fri, 13 Jan 2017 10:18:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/11/2017 03:17 AM, Richard Henderson wrote:
> This lets us expose facilities to TCG_TARGET_HAS_* defines
> directly, rather than hiding behind function calls.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/s390/tcg-target.h | 126
> ++++++++++++++++++++++++----------------------
> tcg/s390/tcg-target.inc.c | 74 +++++++++++----------------
> 2 files changed, 96 insertions(+), 104 deletions(-)
This broke compilation.Seems that you forgot one replacement:
In file included from /home/cborntra/REPOS/qemu/tcg/tcg.c:253:0:
/home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c: In function ‘tgen_cmp’:
/home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c:1096:19: error:
‘facilities’ undeclared (first use in this function)
if (!(facilities & FACILITY_EXT_IMM)) {
^~~~~~~~~~
/home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c:1096:19: note: each
undeclared identifier is reported only once for each function it appears in
/home/cborntra/REPOS/qemu/rules.mak:64: recipe for target 'tcg/tcg.o' failed
make[1]: *** [tcg/tcg.o] Error 1
Makefile:203: recipe for target 'subdir-s390x-softmmu' failed
make: *** [subdir-s390x-softmmu] Error 2
make: Leaving directory '/home/cborntra/REPOS/qemu/build'
- [Qemu-devel] [PULL 03/65] tcg: Add deposit_z expander, (continued)
- [Qemu-devel] [PULL 03/65] tcg: Add deposit_z expander, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 05/65] tcg/arm: Move isa detection to tcg-target.h, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 06/65] tcg/arm: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 07/65] tcg/i386: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 08/65] tcg/mips: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 01/65] tcg: Add field extraction primitives, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 09/65] tcg/ppc: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 12/65] tcg/s390: Support deposit into zero, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 11/65] tcg/s390: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h, Richard Henderson, 2017/01/10
- Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h,
Christian Borntraeger <=
- [Qemu-devel] [PULL 13/65] target-alpha: Use deposit and extract ops, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 19/65] tcg/optimize: Fold movcond 0/1 into setcond, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 14/65] target-arm: Use new deposit and extract ops, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 15/65] target-i386: Use new deposit and extract ops, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 16/65] target-mips: Use the new extract op, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 17/65] target-ppc: Use the new deposit and extract ops, Richard Henderson, 2017/01/10