Re: [Qemu-devel] [PATCH v6 wave 1 4/4] fw-cfg: bump "x-file-slots" to 0x20 for 2.9+ machine types

[Eduardo Habkost]

On Thu, Jan 12, 2017 at 07:24:17PM +0100, Laszlo Ersek wrote:
> More precisely, the "x-file-slots" count is bumped for all machine types
> that:
> (a) use fw_cfg, and
> (b) are not versioned (hence migration is not expected to work for them
>     across QEMU releases anyway), or have version 2.9.
> 
> This affects machine types implemented in the following source files:
> 
> - "hw/arm/virt.c". The "virt-*" machine type is versioned, and the <= 2.8
>   versions already depend on HW_COMPAT_2_8 (see commit e353aac51b944).
>   Therefore adding the "x-file-slots" compat values to HW_COMPAT_2_8
>   suffices.
> 
> - "hw/i386/pc.c". The "pc-i440fx-*" (including "pc-*") and "pc-q35-*"
>   machine types are versioned. Modifying HW_COMPAT_2_8 is sufficient here
>   too (see commit "pc: Add 2.9 machine-types"). The "isapc" machtype is
>   not versioned. The "xenfv" machine type, which uses fw_cfg for direct
>   kernel booting, is also not versioned.
> 
> - "hw/ppc/mac_newworld.c". The "mac99" machine type is not versioned.
> 
> - "hw/ppc/mac_oldworld.c". The "g3beige" machine type is not versioned.
> 
> - "hw/sparc/sun4m.c". None of the 9 machine types defined in this file
>   appear versioned.
> 
> - "hw/sparc64/sun4u.c". None of the 3 machine types defined in this file
>   appear versioned.
> 
> Cc: "Gabriel L. Somlo" <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: Artyom Tarasenko <address@hidden>
> Cc: David Gibson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Mark Cave-Ayland <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Stefano Stabellini <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> Acked-by: Gabriel Somlo <address@hidden>
> Tested-by: Gabriel Somlo <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>

-- 
Eduardo