[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libqtest: handle zero length memwrite/memread
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] libqtest: handle zero length memwrite/memread |
Date: |
Thu, 12 Jan 2017 11:56:36 +0000 |
On 11 January 2017 at 08:49, Greg Kurz <address@hidden> wrote:
> Some recently added tests pass a zero length to qtest_memwrite().
> Unfortunately, the qtest protocol doesn't implement an on-the-wire
> syntax for zero-length writes and the current code happily sends
> garbage to QEMU. This causes intermittent failures.
>
> It isn't worth the pain to enhance the protocol, so this patch
> simply fixes the issue by "just return, doing nothing". The same
> fix is applied to qtest_memread() since the issue also exists in
> the QEMU part of the "memread" command.
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
Thanks; applied to master since it should fix some
intermittent failures in the tests I run on new merges.
-- PMM