[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 27/33] char: fix ctrl-a b not working
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 27/33] char: fix ctrl-a b not working |
Date: |
Wed, 11 Jan 2017 20:35:21 +0100 |
From: Marc-André Lureau <address@hidden>
CharDriverState.be should be updated to point to the current
associated backend.
Fix the regression introduced in the "mux" chardev from commit
a4afa548fc6dd9842ed86639b4d37d4d1c4ad480.
https://bugs.launchpad.net/bugs/1654137
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
qemu-char.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2c9940c..676944a 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -499,7 +499,7 @@ void qemu_chr_fe_printf(CharBackend *be, const char *fmt,
...)
static void remove_fd_in_watch(CharDriverState *chr);
static void mux_chr_set_handlers(CharDriverState *chr, GMainContext *context);
-static void mux_set_focus(MuxDriver *d, int focus);
+static void mux_set_focus(CharDriverState *chr, int focus);
static int null_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
{
@@ -666,7 +666,7 @@ static int mux_proc_byte(CharDriverState *chr, MuxDriver
*d, int ch)
case 'c':
assert(d->mux_cnt > 0); /* handler registered with first fe */
/* Switch to the next registered device */
- mux_set_focus(d, (d->focus + 1) % d->mux_cnt);
+ mux_set_focus(chr, (d->focus + 1) % d->mux_cnt);
break;
case 't':
d->timestamps = !d->timestamps;
@@ -826,8 +826,10 @@ static void mux_chr_set_handlers(CharDriverState *chr,
GMainContext *context)
context, true);
}
-static void mux_set_focus(MuxDriver *d, int focus)
+static void mux_set_focus(CharDriverState *chr, int focus)
{
+ MuxDriver *d = chr->opaque;
+
assert(focus >= 0);
assert(focus < d->mux_cnt);
@@ -836,6 +838,7 @@ static void mux_set_focus(MuxDriver *d, int focus)
}
d->focus = focus;
+ chr->be = d->backends[focus];
mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN);
}
@@ -935,7 +938,9 @@ void qemu_chr_fe_deinit(CharBackend *b)
if (b->chr) {
qemu_chr_fe_set_handlers(b, NULL, NULL, NULL, NULL, NULL, true);
- b->chr->be = NULL;
+ if (b->chr->be == b) {
+ b->chr->be = NULL;
+ }
if (b->chr->is_mux) {
MuxDriver *d = b->chr->opaque;
d->backends[b->tag] = NULL;
@@ -999,7 +1004,7 @@ void qemu_chr_fe_take_focus(CharBackend *b)
}
if (b->chr->is_mux) {
- mux_set_focus(b->chr->opaque, b->tag);
+ mux_set_focus(b->chr, b->tag);
}
}
--
1.8.3.1
- [Qemu-devel] [PULL 16/33] acpi: filter based on CONFIG_ACPI_X86 rather than TARGET, (continued)
- [Qemu-devel] [PULL 16/33] acpi: filter based on CONFIG_ACPI_X86 rather than TARGET, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 18/33] pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 19/33] scsi-block: fix direction of BYTCHK test for VERIFY commands, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 20/33] serial: fix memory leak in serial exit, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 22/33] hxtool: emit Texinfo headings as @subsection, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 21/33] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create(), Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 23/33] x86: ioapic: add traces for ioapic, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 25/33] x86: ioapic: fix fail migration when irqchip=split, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 26/33] exec: Add missing rcu_read_unlock, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 24/33] x86: ioapic: dump version for "info ioapic", Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 27/33] char: fix ctrl-a b not working,
Paolo Bonzini <=
- [Qemu-devel] [PULL 28/33] ramblock-notifier: new, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 29/33] kvm: move cpu synchronization code, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 33/33] Revert "win32: don't run subprocess tests on Mingw32 platform", Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 31/33] Plumb the HAXM-based hardware acceleration support, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 32/33] hax: add Darwin support, Paolo Bonzini, 2017/01/11
- [Qemu-devel] [PULL 30/33] target/i386: Add Intel HAX files, Paolo Bonzini, 2017/01/11
- Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11, no-reply, 2017/01/11
- Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11, Peter Maydell, 2017/01/13