[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/65] tcg: Minor adjustments to deposit expanders
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 02/65] tcg: Minor adjustments to deposit expanders |
Date: |
Tue, 10 Jan 2017 18:17:17 -0800 |
Assert that len is not 0.
Since we have asserted that ofs + len <= N, a later
check for len == N implies that ofs == 0.
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tcg-op.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index c185b9c..b17f03f 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -533,10 +533,11 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1,
TCGv_i32 arg2,
TCGv_i32 t1;
tcg_debug_assert(ofs < 32);
+ tcg_debug_assert(len > 0);
tcg_debug_assert(len <= 32);
tcg_debug_assert(ofs + len <= 32);
- if (ofs == 0 && len == 32) {
+ if (len == 32) {
tcg_gen_mov_i32(ret, arg2);
return;
}
@@ -1718,10 +1719,11 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1,
TCGv_i64 arg2,
TCGv_i64 t1;
tcg_debug_assert(ofs < 64);
+ tcg_debug_assert(len > 0);
tcg_debug_assert(len <= 64);
tcg_debug_assert(ofs + len <= 64);
- if (ofs == 0 && len == 64) {
+ if (len == 64) {
tcg_gen_mov_i64(ret, arg2);
return;
}
--
2.9.3
- [Qemu-devel] [PULL 00/65] tcg 2.9 patch queue, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 02/65] tcg: Minor adjustments to deposit expanders,
Richard Henderson <=
- [Qemu-devel] [PULL 04/65] tcg/aarch64: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 03/65] tcg: Add deposit_z expander, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 05/65] tcg/arm: Move isa detection to tcg-target.h, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 06/65] tcg/arm: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 07/65] tcg/i386: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 08/65] tcg/mips: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 01/65] tcg: Add field extraction primitives, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 09/65] tcg/ppc: Implement field extraction opcodes, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 12/65] tcg/s390: Support deposit into zero, Richard Henderson, 2017/01/10
- [Qemu-devel] [PULL 11/65] tcg/s390: Implement field extraction opcodes, Richard Henderson, 2017/01/10