[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/4] migration: Add a new option to enable on
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/4] migration: Add a new option to enable only-migratable |
Date: |
Tue, 10 Jan 2017 11:02:07 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Ashijeet Acharya (address@hidden) wrote:
> Add a new option "--only-migratable" in qemu which will allow to add
> only those devices which will not fail qemu after migration. Devices
> set with the flag 'unmigratable' cannot be added when this option will
> be used.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> ---
> include/migration/migration.h | 3 +++
> qemu-options.hx | 9 +++++++++
> vl.c | 4 ++++
> 3 files changed, 16 insertions(+)
>
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index c309d23..40b3697 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -38,6 +38,9 @@
> #define QEMU_VM_COMMAND 0x08
> #define QEMU_VM_SECTION_FOOTER 0x7e
>
> +/* for vl.c */
> +extern int only_migratable;
> +
> struct MigrationParams {
> bool blk;
> bool shared;
> diff --git a/qemu-options.hx b/qemu-options.hx
> index c534a2f..1e16ae8 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3574,6 +3574,15 @@ be used to change settings (such as migration
> parameters) prior to issuing
> the migrate_incoming to allow the migration to begin.
> ETEXI
>
> +DEF("only-migratable", 0, QEMU_OPTION_only_migratable, \
> + "-only-migratable allow only migratable devices\n", QEMU_ARCH_ALL)
> +STEXI
> address@hidden -only-migratable
> address@hidden -only-migratable
> +Only allow migratable devices. Devices will not be allowed to enter an
> +unmigratable state.
> +ETEXI
> +
> DEF("nodefaults", 0, QEMU_OPTION_nodefaults, \
> "-nodefaults don't create default devices\n", QEMU_ARCH_ALL)
> STEXI
> diff --git a/vl.c b/vl.c
> index d77dd86..82bffb9 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -180,6 +180,7 @@ bool boot_strict;
> uint8_t *boot_splash_filedata;
> size_t boot_splash_filedata_size;
> uint8_t qemu_extra_params_fw[2];
> +int only_migratable = 0; /* turn it off unless user states otherwise */
QEMU coding style is to omit the =0 for globals.
Other than that,
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Dave
> int icount_align_option;
>
> @@ -3914,6 +3915,9 @@ int main(int argc, char **argv, char **envp)
> }
> incoming = optarg;
> break;
> + case QEMU_OPTION_only_migratable:
> + only_migratable = 1;
> + break;
> case QEMU_OPTION_nodefaults:
> has_defaults = 0;
> break;
> --
> 2.6.2
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK