Re: [Qemu-devel] [PATCH v3] [i.MX] Remove MSGDATA register support.

[jcd]

Le 2017-01-09 12:56, Peter Maydell a écrit :
> On 7 January 2017 at 12:20, Jean-Christophe Dubois 
> <address@hidden> wrote:
> > From the documentation it is not clear what this SPI register is 
> > about.
> >
> > Moreover, neither linux driver nor xvisor driver are using this SPI 
> > register.
> >
> > For now we just remove it and issue a log on register write access.
>
> By the way, could you make sure you use standard commit subject
> line forms like
>  hw/spi/imx_spi.c: Remove ...

OK, I'll do this next time.

> If you put [i.MX] in square brackets like that then patch application
> tools remove it (on the assumption that it's a meta-tag like [PATCH])
> and the commit summary in git ends up just "Remove MSGDATA register 
> support"
> with no indication of what bit of the code it is dealing with.
>
> (I fixed up these two patches manually when I put them into 
> target-arm.)
>
> thanks
> -- PMM