[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ppc: Prevent inifnite loop in decrementer au
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] ppc: Prevent inifnite loop in decrementer auto-reload. |
|
Date: |
Mon, 9 Jan 2017 08:23:47 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/09/2017 07:07 AM, Roman Kapl wrote:
s/inifnite/infinite/ in the subject
> If the DECAR register is set to 0, QEMU tries to reload the decrementer with
> zero in an inifinite loop. According to PPC documentation, the decrementer is
s/inifinite/infinite/
> triggered on 1->0 transition, so avoid reloading the decrementer if if is
> already zero.
>
> The problem does not manifest under Linux, but it is valid to set DECAR to
> zero
> (and may make sense as part of decrementer initialization when interrupts are
> disabled).
When sending a v2, it's best to do it as a new top-level thread rather
than in-reply-to v1, as some patch tools overlook deeply nested replies.
More hints on sending patches:
http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature