Re: [Qemu-devel] [PATCH 17/20] gtk: overwrite the console.c char driver

[Eric Blake]

On 01/05/2017 10:53 AM, Marc-André Lureau wrote:
> Instead of registering a vc handler to allocate the Gtk VC Chardev,
> overwrite the console.c char driver.
> 
> A later patch, when switching to QOM, will register a default console vc
> QOM class if none has been registered before.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  include/sysemu/char.h |  4 +---
>  ui/console.c          | 24 +++++++-----------------
>  ui/gtk.c              | 30 +++++++++++++++++++++---------
>  3 files changed, 29 insertions(+), 29 deletions(-)
> 

>  
> +static const CharDriver gd_vc_driver = {
> +    .instance_size = sizeof(VCChardev),
> +    .kind = CHARDEV_BACKEND_KIND_VC,
> +    .parse = qemu_chr_parse_vc, .create = vc_init,

Might be worth a tweak to split this to two lines.  Either way, R-b stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature