[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH] target-arm/abi32: check for segfault in
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [RESEND PATCH] target-arm/abi32: check for segfault in do_kernel_trap |
|
Date: |
Fri, 6 Jan 2017 15:20:48 +0000 |
On 6 January 2017 at 14:35, Seraphime Kirkovski <address@hidden> wrote:
> In terms of implementation, I find it would be better to extract the
> __kernel_cmpxchg code in a separate function. On the one hand, this
> would avoid code duplication or strange gotos and make do_kernel_trap
> more readable. On the other hand, this would clutter a bit git history.
> If it is acceptable, I will send a patch with those changes. If not,
> will try to find a cleaner solution without creating new functions.
Refactoring the code sounds like a good idea to me -- go ahead.
thanks
-- PMM