[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [m25p80] Abort in case we overrun the internal
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] [m25p80] Abort in case we overrun the internal data buffer |
Date: |
Fri, 6 Jan 2017 10:18:51 +0000 |
On 5 January 2017 at 21:39, Jean-Christophe DUBOIS <address@hidden> wrote:
> So I think this behavior could be triggered either by buggy SPI controller
> emulator or by buggy guest software. And it seems hard to determine where
> the fault comes from from within Qemu. Obviously if the fault is in a Qemu
> emulator we would not want to tag the error as a LOG_GUEST_ERROR. On the
> other hand, it would be nice to warn the user if the guest if it is indeed
> misbehaving so that he can fix his code.
We should log it as a guest error. "warning might be wrong if there's
a bug in QEMU" is true of pretty much any warning we emit...
thanks
-- PMM