[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/display: QOM'ify g364fb.c
|
From: |
赵小强 |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/display: QOM'ify g364fb.c |
|
Date: |
Fri, 6 Jan 2017 08:54:29 +0800 |
在 2017年1月5日，23:10，Peter Maydell <address@hidden> 写道：
>> sysbus_init_irq(sbd, &s->irq);
>> sysbus_init_mmio(sbd, &s->mem_ctrl);
>> sysbus_init_mmio(sbd, &s->mem_vram);
>
> This means we call sysbus_init_mmio() on the MemoryRegion*s
> before we have initialized them. That seems like a bad idea.
Opps，will fix.
> This device is used in the MIPS Jazz machine.
> Can you cc the MIPS maintainers and also Hervé Poussineau
> (the Jazz maintainer) on the next version of this patch,
> please?
OK！