Re: [Qemu-devel] [PATCH v5 0/7] Add support for the Epson RX8900 RTC to the aspeed board

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v5 0/7] Add support for the Epson RX8900 RTC to 
the aspeed board
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
afa239b arm: Add an RX8900 RTC to the ASpeed board
159b9ec tests: Test all implemented RX8900 functionality
6f29754 hw/timer: Add Epson RX8900 RTC support
e42adc4 qtest: Fix whitespace
2c643e3 qtest: Support setting named GPIOs
f325162 qtest: Support named interrupts
870e159 arm: Uniquely name imx25 I2C buses.

=== OUTPUT BEGIN ===
Checking PATCH 1/7: arm: Uniquely name imx25 I2C buses....
Checking PATCH 2/7: qtest: Support named interrupts...
Checking PATCH 3/7: qtest: Support setting named GPIOs...
Checking PATCH 4/7: qtest: Fix whitespace...
Checking PATCH 5/7: hw/timer: Add Epson RX8900 RTC support...
Checking PATCH 6/7: tests: Test all implemented RX8900 functionality...
ERROR: spaces required around that '<' (ctx:WxB)
#347: FILE: tests/rx8900-test.c:313:
+    while (gettimeofday(&now, NULL), timercmp(&now, &end, <)) {
                                                           ^

total: 1 errors, 0 warnings, 894 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/7: arm: Add an RX8900 RTC to the ASpeed board...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden