Re: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1f1aad7 x86: implement la57 paging mode
311ba10 target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns
9d64fcc kvmclock: reduce kvmclock difference on migration
bfa215c kvm: sync linux headers
5f0e361 scsi-disk: fix VERIFY for scsi-block
9476401 hw/block/pflash_cfi*.c: fix confusing assert fail message
7dd43fa multiboot: copy the cmdline verbatim, unescape module strings
fb54977 x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.
da57d9e pc: make pit configurable
4bce027 pc: make sata configurable
34b629c pc: make smbus configurable
34007b1 target-i386: Add Intel SHA_NI instruction support.
f8f5f23 block: drop remaining legacy aio functions in comment
f2653d2 main-loop: update comment for qemu_mutex_lock/unlock_iothread
ee65f85 timer: fix misleading comment in timer.h
3d37cac qemu-timer: check active_timers outside lock/event
1c278a9 virtio-scsi: introduce virtio_scsi_acquire/release
c00ca4e build-sys: remove libtool left-over
9001b30 rules.mak: add more rules to avoid chaining
4e96109 rules.mak: speedup save-vars load-vars
8843247 watchdog: 6300esb: add exit function
ce1b7f7 exec: introduce MemoryRegionCache
c63df91 exec: introduce address_space_extend_translation
5f567e8 exec: introduce memory_ldst.inc.c
0547526 exec: optimize remaining address_space_* cases

=== OUTPUT BEGIN ===
Checking PATCH 1/25: exec: optimize remaining address_space_* cases...
Checking PATCH 2/25: exec: introduce memory_ldst.inc.c...
WARNING: line over 80 characters
#1133: FILE: memory_ldst.inc.c:370:
+        cpu_physical_memory_set_dirty_range(memory_region_get_ram_addr(mr) + 
addr,

total: 0 errors, 1 warnings, 1438 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/25: exec: introduce address_space_extend_translation...
WARNING: line over 80 characters
#22: FILE: exec.c:2942:
+address_space_extend_translation(AddressSpace *as, hwaddr addr, hwaddr 
target_len,

WARNING: line over 80 characters
#85: FILE: exec.c:3016:
+    *plen = address_space_extend_translation(as, addr, len, mr, xlat, l, 
is_write);

total: 0 errors, 2 warnings, 70 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/25: exec: introduce MemoryRegionCache...
WARNING: line over 80 characters
#93: FILE: exec.c:3148:
+#define TRANSLATE(...)           address_space_translate_cached(cache, 
__VA_ARGS__)

WARNING: line over 80 characters
#116: FILE: include/exec/cpu-all.h:193:
+void stl_phys_notdirty_cached(MemoryRegionCache *cache, hwaddr addr, uint32_t 
val);

WARNING: line over 80 characters
#128: FILE: include/exec/cpu-all.h:205:
+                            uint32_t val, MemTxAttrs attrs, MemTxResult 
*result);

WARNING: line over 80 characters
#129: FILE: include/exec/cpu-all.h:206:
+void address_space_stw_cached(MemoryRegionCache *cache, hwaddr addr, uint32_t 
val,

WARNING: line over 80 characters
#131: FILE: include/exec/cpu-all.h:208:
+void address_space_stl_cached(MemoryRegionCache *cache, hwaddr addr, uint32_t 
val,

WARNING: line over 80 characters
#133: FILE: include/exec/cpu-all.h:210:
+void address_space_stq_cached(MemoryRegionCache *cache, hwaddr addr, uint64_t 
val,

WARNING: line over 80 characters
#235: FILE: include/exec/memory.h:1511:
+void address_space_stb_cached(MemoryRegionCache *cache, hwaddr addr, uint32_t 
val,

WARNING: line over 80 characters
#237: FILE: include/exec/memory.h:1513:
+void address_space_stw_le_cached(MemoryRegionCache *cache, hwaddr addr, 
uint32_t val,

WARNING: line over 80 characters
#239: FILE: include/exec/memory.h:1515:
+void address_space_stw_be_cached(MemoryRegionCache *cache, hwaddr addr, 
uint32_t val,

WARNING: line over 80 characters
#241: FILE: include/exec/memory.h:1517:
+void address_space_stl_le_cached(MemoryRegionCache *cache, hwaddr addr, 
uint32_t val,

WARNING: line over 80 characters
#243: FILE: include/exec/memory.h:1519:
+void address_space_stl_be_cached(MemoryRegionCache *cache, hwaddr addr, 
uint32_t val,

WARNING: line over 80 characters
#245: FILE: include/exec/memory.h:1521:
+void address_space_stq_le_cached(MemoryRegionCache *cache, hwaddr addr, 
uint64_t val,

WARNING: line over 80 characters
#247: FILE: include/exec/memory.h:1523:
+void address_space_stq_be_cached(MemoryRegionCache *cache, hwaddr addr, 
uint64_t val,

total: 0 errors, 13 warnings, 281 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/25: watchdog: 6300esb: add exit function...
Checking PATCH 6/25: rules.mak: speedup save-vars load-vars...
Checking PATCH 7/25: rules.mak: add more rules to avoid chaining...
Checking PATCH 8/25: build-sys: remove libtool left-over...
Checking PATCH 9/25: virtio-scsi: introduce virtio_scsi_acquire/release...
Checking PATCH 10/25: qemu-timer: check active_timers outside lock/event...
Checking PATCH 11/25: timer: fix misleading comment in timer.h...
Checking PATCH 12/25: main-loop: update comment for 
qemu_mutex_lock/unlock_iothread...
Checking PATCH 13/25: block: drop remaining legacy aio functions in comment...
Checking PATCH 14/25: target-i386: Add Intel SHA_NI instruction support....
WARNING: line over 80 characters
#35: FILE: target/i386/cpu.h:624:
+#define CPUID_7_0_EBX_SHA_NI   (1U << 29) /* SHA1/SHA256 Instruction 
Extensions */

total: 0 errors, 1 warnings, 15 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/25: pc: make smbus configurable...
Checking PATCH 16/25: pc: make sata configurable...
Checking PATCH 17/25: pc: make pit configurable...
Checking PATCH 18/25: x86: Fix x86_64 'g' packet response to gdb from 32-bit 
mode....
Checking PATCH 19/25: multiboot: copy the cmdline verbatim, unescape module 
strings...
WARNING: line over 80 characters
#45: FILE: hw/i386/multiboot.c:300:
+            next_initrd = get_opt_value(tmpbuf, sizeof(tmpbuf), 
initrd_filename);

ERROR: do not use assignment in if condition
#53: FILE: hw/i386/multiboot.c:305:
+            if ((next_space = strchr(tmpbuf, ' ')))

ERROR: braces {} are necessary for all arms of this statement
#53: FILE: hw/i386/multiboot.c:305:
+            if ((next_space = strchr(tmpbuf, ' ')))
[...]

total: 2 errors, 1 warnings, 49 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 20/25: hw/block/pflash_cfi*.c: fix confusing assert fail 
message...
Checking PATCH 21/25: scsi-disk: fix VERIFY for scsi-block...
Checking PATCH 22/25: kvm: sync linux headers...
Checking PATCH 23/25: kvmclock: reduce kvmclock difference on migration...
Checking PATCH 24/25: target-i386: Fix eflags.TF/#DB handling of syscall/sysret 
insns...
Checking PATCH 25/25: x86: implement la57 paging mode...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden