Re: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape module strings

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape 
module strings
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
951c8be multiboot: copy the cmdline verbatim, unescape module strings

=== OUTPUT BEGIN ===
Checking PATCH 1/1: multiboot: copy the cmdline verbatim, unescape module 
strings...
WARNING: line over 80 characters
#42: FILE: hw/i386/multiboot.c:299:
+            next_initrd = (char *)get_opt_value(tmpbuf, sizeof(tmpbuf), 
initrd_filename);

ERROR: do not use assignment in if condition
#50: FILE: hw/i386/multiboot.c:304:
+            if ((next_space = strchr(tmpbuf, ' ')))

ERROR: braces {} are necessary for all arms of this statement
#50: FILE: hw/i386/multiboot.c:304:
+            if ((next_space = strchr(tmpbuf, ' ')))
[...]

total: 2 errors, 1 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden