[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: fix crash when fsdev is missing
From: |
Li Qiang |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: fix crash when fsdev is missing |
Date: |
Tue, 20 Dec 2016 10:01:26 +0800 |
On 2016-12-19 22:28 GMT+08:00 Greg Kurz <address@hidden> wrote:
> If the user passes -device virtio-9p without the corresponding -fsdev, QEMU
> dereferences a NULL pointer and crashes.
>
> This is a 2.8 regression introduced by commit 702dbcc274e2c.
>
> Signed-off-by: Greg Kurz <address@hidden>
>
Reviewed-by: Li Qiang <address@hidden>
> ---
> hw/9pfs/9p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index faebd91f5fab..68725b7a1c97 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -3521,7 +3521,7 @@ int v9fs_device_realize_common(V9fsState *s, Error
> **errp)
> rc = 0;
> out:
> if (rc) {
> - if (s->ops->cleanup && s->ctx.private) {
> + if (s->ops && s->ops->cleanup && s->ctx.private) {
> s->ops->cleanup(&s->ctx);
> }
> g_free(s->tag);
>
>