[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key mater
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free |
Date: |
Sun, 11 Dec 2016 04:51:19 +0200 |
On Thu, Dec 08, 2016 at 09:20:07AM -0600, Eric Blake wrote:
> On 12/07/2016 08:33 PM, Gonglei (Arei) wrote:
>
> >> Sensitive information is sometimes also held in mlocked pages to prevent
> >> it being swapped to disk, but qemu in general is not currently taking
> >> that level of precaution (see also commit 8813800b).
> >>
> >>>
> >>> Let's zeroize the memory of CryptoDevBackendSymOpInfo structure pointed
> >>> for key material security.
> >>>
> >>> [v2: Stefan perfects the commit message, thanks]
> >>
> >> The v2 blurb should appear after the --- line, as it is nice for
> >> reviewers but a year from now when reading 'git log' we won't care how
> >> many versions were on the list, only about the one version in git.
> >>
> > Yes, you are right. I just wanted to keep the Stefan's work because
> > the most of commit message comes from him. :)
>
> Then I might have written:
>
> [Thanks to Stefan for help with crafting the commit message]
>
> >
> >>> Signed-off-by: Gonglei <address@hidden>
> >>> Reviewed-by: Stefan Hajnoczi <address@hidden>
> >>> ---
> >>> hw/virtio/virtio-crypto.c | 13 ++++++++++++-
> >>> 1 file changed, 12 insertions(+), 1 deletion(-)
> >>>
> >>
> >> The commit message may still need improvement, but the maintainer might
> >> be willing to do that without needing a v3. At any rate,
> >> Reviewed-by: Eric Blake <address@hidden>
> >>
> > Thanks.
>
> We'll see what the maintainer thinks :)
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
I'd suggest post v3 after 2.8 is out.
--
MST
Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Max Reitz, 2016/12/07
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Gonglei (Arei), 2016/12/07
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Eric Blake, 2016/12/08
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Max Reitz, 2016/12/08
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Gonglei (Arei), 2016/12/08
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Max Reitz, 2016/12/09
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Gonglei (Arei), 2016/12/09
- Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free, Max Reitz, 2016/12/10