[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/14] tests: Add test-image-lock
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH 14/14] tests: Add test-image-lock |
|
Date: |
Fri, 9 Dec 2016 15:39:20 +0800 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, 12/02 17:30, Max Reitz wrote:
> > +static struct CompatData {
> > + bool write_1;
> > + bool share_1;
> > + bool write_2;
> > + bool share_2;
> > + bool compatible;
> > +} compat_data[] = {
> > + /* Write 1, Share 1, Write 2, Share 2, Compatible. */
> > + { RO, SHARE, RO, SHARE, true, },
> > + { RO, SHARE, RO, EXCLU, true, },
> > + { RO, SHARE, RW, SHARE, true, },
> > + { RO, SHARE, RW, EXCLU, true, },
> > + { RO, EXCLU, RO, SHARE, true, },
> > + { RO, EXCLU, RO, EXCLU, true, },
> > + { RO, EXCLU, RW, SHARE, false, },
> > + { RO, EXCLU, RW, EXCLU, false, },
> > +};
>
> Without having looked closer at the test, what about RW/RW compatibility?
Good catch, I will fix this matrix in next version.
Fam