qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] ARM BE8/BE32 semihosting and gdbstub suppor


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/5] ARM BE8/BE32 semihosting and gdbstub support.
Date: Tue, 6 Dec 2016 16:14:41 +0000

On 6 December 2016 at 15:51, Julian Brown <address@hidden> wrote:
> On Tue, 6 Dec 2016 15:44:07 +0000
> Peter Maydell <address@hidden> wrote:
>
>> On 6 December 2016 at 15:11, Julian Brown <address@hidden>
>> wrote:
>> > On Thu, 3 Nov 2016 22:23:09 +0000
>> > Peter Maydell <address@hidden> wrote:
>> >
>> >> Strong 'no' for the approach of having different CPU
>> >> names, I'm afraid. What you want is to have a CPU
>> >> property which works like the hardware CPU's CFGEND
>> >> signal to set the reset value of the SCTLR.EE bit. Then
>> >> a board can use that where it would wire up CFGEND
>> >> in real hardware, and on the command line you can
>> >> have -cpu whatever,cfgend=yes (which is a bit ugly
>> >> but then it's borderline whether it makes any sense at
>> >> all for the user to be able to set the endianness on
>> >> the commandline).
>> >
>> > How about something like this?
>>
>> Could you send that as an inline patch rather than
>> an attachment? Patches hidden in attachments are kind
>> of painful to deal with.
>
> Does this work? Sorry, sending replies direct from git is the level
> past the one I've got to so far :-).

Yes, this works; it's probably easiest to just send a v2
of the patchset, though, since I notice you sent followups
with patches to most of the original patch emails.

This patch looks like it's trying to do too many
things at once; "add property which allows config of the
SCTLR.EE reset value" should definitely be its own patch,
and there may be other useful things that could be split
out of it.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]